Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with appInfo() reading past end of buffer #51

Closed
wants to merge 1 commit into from
Closed

Fix crash with appInfo() reading past end of buffer #51

wants to merge 1 commit into from

Commits on Oct 7, 2024

  1. Fix crash with appInfo() reading past end of buffer 

    This is a bug because the APDU proxy does not send back any flags unless
you use HAVE_BOLOS define when building the SDK for the device. This
does not seem to be built in on the NANO S PLUS target. That means using
appInfo() will crash because it assumes you get flags back but they are
never sent.

See supporting documentation and code here,
- https://github.com/LedgerHQ/ledger-secure-sdk/blob/cb5cfae5750d57e4c03460c5c93098fea7a8abcb/include/sdk_apdu_commands.h#L8-L32
- https://github.com/LedgerHQ/ledger-secure-sdk/blob/cb5cfae5750d57e4c03460c5c93098fea7a8abcb/src/os_io_seproxyhal.c#L1156-L1161
    @NullSoldier
    NullSoldier committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2446306 View commit details
    Browse the repository at this point in the history