QR code source path is now used explicitly #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
explicit_qrcode_source_path
branch
from
bfcf23b
to
8f33c0c
Compare
apaillier-ledger
force-pushed
the
explicit_qrcode_source_path
branch
from
8f33c0c
to
fd76eee
Compare
apaillier-ledger
changed the title
carlosala
approved these changes
Aug 3, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of this PR : LedgerHQ/ledger-secure-sdk#397
There is a breaking change for Stax applications using the QR code feature relying on the SDK to have it already in its source path.