Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widget): initial implementation of stateful rendering #83

Closed
wants to merge 10 commits into from

Conversation

a-kenji
Copy link
Owner

@a-kenji a-kenji commented Sep 13, 2023

Opened this branch, because I don't have permissions to push to #82

  • fix stateful widget example
  • simplify spawn function
  • gate input handling behind unstable feature flag
  • implement an async version
  • implement viewport Implement ViewPort #14
  • benchmark stateful version
  • add tests for input handling, with different terminal variants
  • write documentation
  • add stateful sync/async examples to test builds
  • optionally? add tracing crate for input handling events, to make it less of a black box
  • carry reference to the child process e.g. a child killer
  • (optional) buffered event handling
  • add a timeout to the parser thread (when it gets sizes of 0).

@lthoerner
Copy link

What is preventing you from merging #82 ?

@a-kenji
Copy link
Owner Author

a-kenji commented Sep 25, 2023

It is far from being done.

@lthoerner
Copy link

It is far from being done.

Oh, I misread your original post.

@a-kenji
Copy link
Owner Author

a-kenji commented Jan 13, 2024

I think the stateful Widget is too complicated to reason about currently, while the Input handler is not refined yet.

So I will go with a different Interface for now.

The initial direction is in #133

@a-kenji a-kenji closed this Jan 13, 2024
@a-kenji a-kenji deleted the feat/stateful-input-widget branch March 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants