fix(autoware_multi_object_tracker): fix passedByValue (autowarefounda…

…tion#8231) fix:passedByValue Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
a-maumau · Jul 29, 2024 · 99eb65b · 99eb65b
1 parent 0220122
commit 99eb65b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/perception/autoware_multi_object_tracker/src/debugger/debug_object.cpp b/perception/autoware_multi_object_tracker/src/debugger/debug_object.cpp
@@ -51,7 +51,7 @@ int32_t uuidToInt(const boost::uuids::uuid & uuid)
 namespace autoware::multi_object_tracker
 {
 
-TrackerObjectDebugger::TrackerObjectDebugger(std::string frame_id)
+TrackerObjectDebugger::TrackerObjectDebugger(const std::string & frame_id)
 {
   // set frame id
   frame_id_ = frame_id;
@@ -173,7 +173,7 @@ void TrackerObjectDebugger::process()
 }
 
 void TrackerObjectDebugger::draw(
-  const std::vector<std::vector<ObjectData>> object_data_groups,
+  const std::vector<std::vector<ObjectData>> & object_data_groups,
   visualization_msgs::msg::MarkerArray & marker_array) const
 {
   // initialize markers

diff --git a/perception/autoware_multi_object_tracker/src/debugger/debug_object.hpp b/perception/autoware_multi_object_tracker/src/debugger/debug_object.hpp
@@ -65,7 +65,7 @@ struct ObjectData
 class TrackerObjectDebugger
 {
 public:
-  explicit TrackerObjectDebugger(std::string frame_id);
+  explicit TrackerObjectDebugger(const std::string & frame_id);
 
 private:
   bool is_initialized_{false};
@@ -96,7 +96,7 @@ class TrackerObjectDebugger
 
   void reset();
   void draw(
-    const std::vector<std::vector<ObjectData>> object_data_groups,
+    const std::vector<std::vector<ObjectData>> & object_data_groups,
     visualization_msgs::msg::MarkerArray & marker_array) const;
   void process();
   void getMessage(visualization_msgs::msg::MarkerArray & marker_array) const;