Support full fine-tuning auxiliaries part ii #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Jan 9, 2025
|
Could this be opened against #192 branch so that all changes could be merged together in one go? |
a-r-r-o-w
approved these changes
Jan 9, 2025
finetrainers/trainer.py
Outdated
| f"Loading adapter weights from state_dict led to unexpected keys not found in the model: " | ||
| f" {unexpected_keys}. " | ||
| if self.args.training_type == "lora": | ||
| transformer_ = transformer_cls_.__class__.from_pretrained( |
There was a problem hiding this comment.
Maybe missing some context here, but do we need __class__ on the transformer_cls_ class ref? No problem even if not required since you've tested this to work already. Asking because, in the other branch, just transformer_cls_.from_pretrained is used
There was a problem hiding this comment.
You're right. Thanks for catching. I have removed it.
|
Closing as I pushed my updates to #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with all three currently supported models.