Add support for RISC-V #172
Open
+84,179
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
approved these changes
Jan 7, 2025
|
Hello @bcoles, Cool, thanks for your work and interest to this project! Some thoughts for the beginning:
|
No, we don't need all three. I have replaced these with one:
I thought the included defconf files were supposed to represent the mainline defaults. The other defconf files in the repository certainly do not pass - they result in multiple failures. Perhaps I misunderstand. Can you elaborate? |
I mean For example, It's the first thing that we need to fix in this pull request:
After this work, our Thank you! |
|
Thanks.
That makes sense. I have implemented these changes.
I have implemented these changes for Output: |
|
As for the checks, KSPP Recommended Settings does not currently have recommendations for RISC-V, but some of the existing recommendations for other architectures are likely to be applicable. These may need to be assessed individually. For example:
Do you have a suggestion for the |
Sure, I can add config files for a few distros. Unfortunately https://github.com/oracle/kconfigs does not have KConfig files for RISC-V systems. Is there a better approach than pulling the config from |
I've added OpenSUSE to the I've added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RISC-V. Fixes #56.
generate defconfig
The provided kernel config files were generated using the RISC-V toolchain (gcc):
git checkout v6.9 PATH="/home/user/Desktop/riscv/bin:$PATH" ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- make defconfig mv .config ../kernel-hardening-checker/kernel_hardening_checker/config_files/defconfigs/riscv_defconfig_6.9.config(I can also provide configs built with
muslif that would be of any use.)detect_arch_by_kconfig()
Kernel configs for both 32-bit and 64-bit RISC-V systems use
CONFIG_RISCV_*.detect_arch_by_kconfig()uses"RISCV"for architecture detection, ignoring bit-width.detect_arch_by_sysctl()
I examined multiple Linux RISC-V systems, many of which did not populate the
kernel.archsysctl.detect_arch_by_sysctl()usesriscv32andriscv64for 32-bit and 64-bit respectively.uname -mprovides the same values. Perhaps a newdetect_arch_by_uname()function should be added as a fallback.Example Output
Example output on
debian-20240128-convert_riscv64-virtin Qemu:Output: