-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new forge frontend #118
Conversation
src/halmos/__main__.py
Outdated
result = {} # compiler version -> source filename -> contract name -> (json, type) | ||
|
||
out_path = os.path.join(args.root, args.forge_build_out) | ||
if not os.path.exists(out_path): raise ValueError('not exist', out_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not os.path.exists(out_path): raise ValueError('not exist', out_path) | |
if not os.path.exists(out_path): raise ValueError(f'{out_path} does not exist') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, we may want to throw the built-in FileNotFoundError
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments otherwise LGTM! 👌
reimplement forge frontend without crytic-compile dependency