test: more regression tests + external tests #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
daejunpark
commented
Jul 17, 2023
•
daejunpark
commented
- add more regression tests, including assertion violation cases
- add --json-output option to output test results in json
- add new pytest that runs all regression tests
- add external tests
| @@ -1,30 +1,32 @@ | |||
| // SPDX-License-Identifier: AGPL-3.0 | |||
| pragma solidity >=0.8.0 <0.9.0; | |||
|
|
|||
| // NOTE: required options: --loop 4 --symbolic-storage | |||
There was a problem hiding this comment.
out of scope for this but it would be really great if we could annotate it at the contract or method level
/// @custom:halmos loop=4
/// @custom:halmos symbolic-storage=true
There was a problem hiding this comment.
yes, it would be great! it's on the todo list.
src/halmos/__main__.py
Outdated
| @@ -1089,7 +1114,7 @@ def parse_build_out(args: argparse.Namespace) -> Dict: | |||
| return result | |||
|
|
|||
|
|
|||
| def main() -> int: | |||
| def main(argv=None, test_results_map=None) -> int: | |||
There was a problem hiding this comment.
it seems a little odd to pass a "write argument" to main, but ok 🙃 could use a docstring explaining that it's basically for testing, to essentially avoid going through file IO right?
There was a problem hiding this comment.
i wasn't happy with this either, but did so to avoid unnecessary asdict conversion for test results in normal execution. i refactored the code to improve this, and now it explicitly returns the test results.
karmacoma-eth
approved these changes
Jul 18, 2023
daejunpark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.