Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic runner for baolean/symexec-bench #135

Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat: add basic runner for baolean/symexec-bench #135

merged 1 commit into from
Jul 21, 2023

Conversation

karmacoma-eth
Copy link
Collaborator

basic runner to make it easier to compare perf numbers across halmos versions

@karmacoma-eth
Copy link
Collaborator Author

Could use a couple more bells and whistles:

  • it clones in the current working directory, which makes it dirty wrt git. Might be better to checkout the external repo in a well defined location that is added to .gitignore?
  • it would be nice to check that we get the expected output for a given test, otherwise the perf number is meaningless but not sure where to specify that

daejunpark
daejunpark approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@daejunpark daejunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start. we can further organize benchmarking stuffs when we discuss the eth-sc-comp.

@daejunpark daejunpark merged commit fec4bba into main Jul 21, 2023
21 checks passed
@daejunpark daejunpark deleted the benchmarks branch July 21, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daejunpark daejunpark daejunpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karmacoma-eth @daejunpark