Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit message when we find a library placeholder #158

Merged
merged 2 commits into from
Aug 3, 2023
Merged

add explicit message when we find a library placeholder #158

merged 2 commits into from
Aug 3, 2023

Conversation

karmacoma-eth
Copy link
Collaborator

Before:

Error: None failed: ValueError: non-hexadecimal number found in fromhex() arg at position 104

After:

WARNING:Halmos:contract hexcode contains library placeholder
(see https://github.com/a16z/halmos/wiki/warnings#library-placeholder)
Error: None failed: ValueError: non-hexadecimal number found in fromhex() arg at position 104 (hexcode=6080604052348015600e575f80fd5b50600436106026575f3560e01c8063e6d8ab5714602a575b5f80fd5b60306032565b005b73__$72fd9f18565b1bf49af679aa1eb458ccdd$__63c29855786040518163ffffffff1660e01b8152600401602060405180830381865af41580156078573d5f803e3d5ffd5b505050506040513d601f19601f82011682018060405250810190609a919060a8565b60011460a65760a660be565b565b5f6020828403121560b7575f80fd5b5051919050565b634e487b7160e01b5f52600160045260245ffdfea2646970667358221220718127b2b6ab931470aa18feed33867fe44f4298c582940b611bde59dc4d049664736f6c63430008140033)

@karmacoma-eth
add explicit message when we find a library placeholder
5d6792e 
Before:

    Error: None failed: ValueError: non-hexadecimal number found in fromhex() arg at position 104

After:

    WARNING:Halmos:contract hexcode contains library placeholder
    (see https://github.com/a16z/halmos/wiki/warnings#library-placeholder)
    Error: None failed: ValueError: non-hexadecimal number found in fromhex() arg at position 104 (hexcode=6080604052348015600e575f80fd5b50600436106026575f3560e01c8063e6d8ab5714602a575b5f80fd5b60306032565b005b73__$72fd9f18565b1bf49af679aa1eb458ccdd$__63c29855786040518163ffffffff1660e01b8152600401602060405180830381865af41580156078573d5f803e3d5ffd5b505050506040513d601f19601f82011682018060405250810190609a919060a8565b60011460a65760a660be565b565b5f6020828403121560b7575f80fd5b5051919050565b634e487b7160e01b5f52600160045260245ffdfea2646970667358221220718127b2b6ab931470aa18feed33867fe44f4298c582940b611bde59dc4d049664736f6c63430008140033)
@daejunpark daejunpark enabled auto-merge (squash) August 3, 2023 22:05
@daejunpark daejunpark merged commit fc61d2f into main Aug 3, 2023
90 of 91 checks passed
@daejunpark daejunpark deleted the handle-library-placeholder branch August 3, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daejunpark daejunpark daejunpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karmacoma-eth @daejunpark