fix workflows #330
Merged
fix workflows #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, this only triggers on push to `branch AND path`, when we wanted `branch OR path`
Wiz Scan Summary
|
It didn't improve speed significantly. We rely on forge to pull the required submodules during the pytest run.
This reverts commit e169cae. Much slower than yices, 1h37 vs 25min
daejunpark
reviewed
Jul 25, 2024
| [submodule "tests/lib/multicaller"] | ||
| path = tests/lib/multicaller | ||
| url = https://github.com/Vectorized/multicaller | ||
| shallow = true |
There was a problem hiding this comment.
what's the effect of this in the normal dev setting for cloning and updating submodules? is this better than having the ci script to use --depth 1 when cloning?
There was a problem hiding this comment.
not clear, didn't seem to move metrics. It's also weirdly hard to test, because I can't check out this commit directly. I'm not convinced this does anything 😫
daejunpark
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.