feat: support for new cheatcode of generating calldata #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
commented
Sep 2, 2024
daejunpark
commented
Sep 2, 2024
daejunpark
commented
Sep 3, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
karmacoma-eth
approved these changes
Sep 12, 2024
This reverts commit d004c97.
|
@karmacoma-eth i've addressed all your comments, and implemented some todo items. this should be enough for the scope of this pr. please take another look when you get a chance. |
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Sep 19, 2024
### 🕓 Changelog [`halmos`](https://github.com/a16z/halmos) has released support for the following new cheat codes via PRs [#360](a16z/halmos#360) and (small patch) [#364](a16z/halmos#364): ```solidity createCalldata(string contractName); createCalldata(string contractName, bool includeViewFunctions); createCalldata(string filename, string contractName); createCalldata(string filename, string contractName, bool includeViewFunctions); ``` > Please note that `includeViewFunctions` defaults to `false`, if not provided. This PR refactors the `halmos`-based tests to capitalise on these new cheat codes. To verify the correct behaviour of the Vyper compiler for `view` and `pure` functions, we include read-only functions in the calldata creation. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done:
note:
contractNamecan be either a contract or an interface name.includeViewFunctionsdefaults to false, if not provided.future work: