fix: vm.etch() leaves storage uninitialized #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this means that running etch'ed bytecode that reads from storage can result in KeyErrors from ex.storage fixes #362
|
TODO: add test, but it fixes the repro in #362 |
daejunpark
reviewed
Sep 17, 2024
| @@ -721,6 +723,9 @@ def handle(sevm, ex, arg: ByteVec, stack, step_id) -> ByteVec | None: | |||
| code_bytes = arg[code_loc : code_loc + code_length] | |||
| ex.set_code(who, code_bytes) | |||
|
|
|||
| # vm.etch() initializes but does not clear storage | |||
| ex.storage.setdefault(who, sevm.mk_storagedata()) | |||
|
|
|||
daejunpark
reviewed
Sep 17, 2024
src/halmos/cheatcodes.py
Outdated
|
|
||
| sevm.sstore(ex, store_account_alias, store_slot, store_value) | ||
| sevm.sstore(ex, store_account, store_slot, store_value) |
There was a problem hiding this comment.
allowing vm.store() on empty accounts needs further discussions. can we focus on the vm.etch() fix in this pr, without making the above changes to vm.store()?
There was a problem hiding this comment.
ok, reverted the vm.store change in 55fba55
daejunpark
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this means that running etch'ed bytecode that reads from storage can result in KeyErrors from ex.storage
fixes #362