fix: concretize calldatacopy #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: karmacoma <karma@coma.lol>
karmacoma-eth
approved these changes
Sep 17, 2024
daejunpark
commented
Sep 18, 2024
karmacoma-eth
approved these changes
Sep 18, 2024
|
|
||
| data = self.data | ||
| # TODO: call substitute() only when the data contains variables to be substituted | ||
| new_data = substitute(data, *substitution.items()) |
There was a problem hiding this comment.
I am slightly worried about the perf impact of substitute always constructing a new object, but I guess we'll see how it looks like when I profile (not a blocker)
There was a problem hiding this comment.
yeah, proper profiling would be greatly helpful. based on my performance tests, it gets slower if data is a complex term, e.g., LibUint1024Test:testProveSubAdd().
i'm thinking applying this substitution to selected int_of() only, rather than blindly applying to all calldatacopy. would be a separate pr though.
karmacoma-eth
approved these changes
Sep 18, 2024
Co-authored-by: karmacoma <karma@coma.lol>
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Sep 19, 2024
### 🕓 Changelog [`halmos`](https://github.com/a16z/halmos) has released support for the following new cheat codes via PRs [#360](a16z/halmos#360) and (small patch) [#364](a16z/halmos#364): ```solidity createCalldata(string contractName); createCalldata(string contractName, bool includeViewFunctions); createCalldata(string filename, string contractName); createCalldata(string filename, string contractName, bool includeViewFunctions); ``` > Please note that `includeViewFunctions` defaults to `false`, if not provided. This PR refactors the `halmos`-based tests to capitalise on these new cheat codes. To verify the correct behaviour of the Vyper compiler for `view` and `pure` functions, we include read-only functions in the calldata creation. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
daejunpark
added a commit
that referenced
this pull request
Sep 24, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two instructions that read calldata, and their concretization logic works as follows:
this behavior is based on typical calldata decoding logic, where the length of dynamic arguments is first read using calldataload, and their data is then read using either calldataload or calldatacopy. for example, see the test provided in #371.