Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solvers and halmos-builder dockerfiles #404

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Conversation

karmacoma-eth
Copy link
Collaborator

@karmacoma-eth karmacoma-eth commented Nov 8, 2024

there is an issue where jsi exits because in the docker environment, bash (i.e. jsi's parent) has PID 1

next steps:

  • fix jsi and release a jsi update
  • rebuild solvers and halmos-builder with that new version
  • the new dockerfiles should not require new changes

with these images, we can run foundryup in CI to always run with the latest foundry

this will let us update foundry from inside the docker image, instead of required a rebuild
@karmacoma-eth karmacoma-eth changed the title Chore workflows update solvers and halmos-builder dockerfiles Nov 8, 2024
@a16z a16z deleted a comment from wiz-a16z bot Nov 8, 2024
- clang is needed to build pysha3
- ENTRYPOINT has annoying ergonomics, having a default CMD turns out to be nicer
@wiz-a16z
Copy link

wiz-a16z bot commented Nov 8, 2024

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 1 0 1 0 2
Vulnerabilities 0 0 0 0 0 0
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 1 0 1 0 2

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@karmacoma-eth karmacoma-eth merged commit 29d9484 into main Nov 8, 2024
67 of 87 checks passed
@karmacoma-eth karmacoma-eth deleted the chore-workflows branch November 8, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants