-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update solvers and halmos-builder dockerfiles #404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will let us update foundry from inside the docker image, instead of required a rebuild
karmacoma-eth
changed the title
Chore workflows
update solvers and halmos-builder dockerfiles
Nov 8, 2024
- clang is needed to build pysha3 - ENTRYPOINT has annoying ergonomics, having a default CMD turns out to be nicer
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
daejunpark
reviewed
Nov 8, 2024
daejunpark
reviewed
Nov 8, 2024
daejunpark
reviewed
Nov 8, 2024
daejunpark
reviewed
Nov 8, 2024
Co-authored-by: Daejun Park <daejunpark@gmail.com>
Co-authored-by: Daejun Park <daejunpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is an issue where jsi exits because in the docker environment, bash (i.e. jsi's parent) has PID 1
next steps:
solvers
andhalmos-builder
with that new versionwith these images, we can run
foundryup
in CI to always run with the latest foundry