test: push notification e2e tests

[lkawka]

Description

This PR adds two end-to-end tests for push notifications, designed to verify that the default push notification implementation functions as expected. These tests involve setting up two distinct servers: an agent server that hosts a basic test agent, and a notifications server responsible for receiving notifications from the agent server.

BEGIN_COMMIT_OVERRIDE
test: push notification e2e tests
END_COMMIT_OVERRIDE

[gemini-code-assist]

Summary of Changes

Hello @lkawka, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements comprehensive end-to-end tests to validate the default push notification system. It sets up a robust testing infrastructure, including a simulated agent server and a dedicated notification ingestion server, to ensure that push notifications are correctly triggered, sent, and received under various configuration scenarios, thereby enhancing the reliability of the notification mechanism.

Highlights

• New E2E Tests: Introduces two end-to-end tests specifically for push notification functionality.
• Dual Server Setup: Establishes a testing environment involving a dedicated agent server and a notifications server.
• Agent Server Simulation: The agent server hosts a basic test agent capable of handling messages and triggering notifications.
• Notification Ingestion: The notifications server is designed to receive and store push notifications for verification.
• Config Validation: Tests cover scenarios where push notification configurations are provided in-message and updated separately.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds end-to-end tests for push notifications, which is a great addition for ensuring the feature works as expected. The tests are well-structured, using separate processes for the agent and notification servers, and include good patterns like polling with timeouts. My review includes a few suggestions for minor improvements, such as fixing typos, improving error handling in the test notification server, and using more specific exception types.

[mikeas1]

Overall the structure looks good, just had a few small comments.