-
Notifications
You must be signed in to change notification settings - Fork 271
feat(client): allow specifying historyLength via call-site MessageSendConfiguration in BaseClient.send_message #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TadakiAsechi
wants to merge
8
commits into
a2aproject:main
Choose a base branch
from
TadakiAsechi:feat/client-send-message-config-merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
41f4456
test(client): add tests for call-site MessageSendConfiguration merge …
tadaki0601 cab68ed
style(client): apply linter formatting to BaseClient and related tests
tadaki0601 234e23c
fix(client): merge call-site MessageSendConfiguration using field nam…
tadaki0601 bb135cb
test(client): improve readability in BaseClient send_message tests
tadaki0601 6afdbcd
test: improve naming and readability in BaseClient send_message confi…
tadaki0601 c84c455
chore(test): apply formatting and minor lint fixes in send_message co…
tadaki0601 3502183
Merge branch 'main' into feat/client-send-message-config-merge
holtskinner 91781f9
Merge branch 'main' into feat/client-send-message-config-merge
TadakiAsechi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.