Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Thoughts #251

Closed
wants to merge 3 commits into from
Closed

Conversation

uanik03
Copy link

@uanik03 uanik03 commented Jul 13, 2024

Introducing Thoughts

Description

At the moment, users can write blogs. Blogs are long form content. User can write a thought. Thoughts are short form.

Resolves #249

Linked Issues

#249

Type of Change

  • New feature (non-breaking change which adds functionality)

Changes

  • backend/src/routes/thought.ts - thoughtRouter (CRUD ops for thought feature)
  • frontend/src/pages/Thought.ts - (page to test all features)
  • ...

Screenshots/Recordings

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there are no similar/duplicate pull requests regarding the same issue
  • My changes follow the project's coding guidelines and best practices
  • Code is formatted properly and lint check passes successfully
  • I have made corresponding changes to the documentation (if applicable)

Additional Notes

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medium-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 10:10am

@uanik03 uanik03 changed the title add feature:thought. (issue: #249 add feature:thought. (issue: #249) Jul 14, 2024
@uanik03
Copy link
Author

uanik03 commented Jul 14, 2024

change the BACKEND_URL in config.ts

Comment on lines 1 to 2
// export const BACKEND_URL = 'https://backend.aadesh-kulkarni08.workers.dev';
export const BACKEND_URL = 'http://localhost:39013';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BACKEND_URL should be pointing to workers.dev, not localhost. Please rollback changes to this file.

Comment on lines 75 to 82
<Link to="/thoughts">
<button
type="button"
className="focus:outline-none hover:bg-sub rounded-3xl focus:ring-4 focus:ring-gray-100 font-medium flex items-center gap-2 text-sm px-3 md:px-5 py-2.5"
>
<WriteIcon /> thought
</button>
</Link>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

"content" TEXT NOT NULL,
"publishedDate" TIMESTAMP(3) NOT NULL DEFAULT CURRENT_TIMESTAMP,
"published" BOOLEAN NOT NULL DEFAULT false,
"authorId" TEXT NOT NULL,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

author        User       @relation(fields: [authorId], references: [id], onDelete: Cascade)
authorId      String

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadeshkulkarni what should I change here?

@@ -0,0 +1,13 @@
-- CreateTable
CREATE TABLE "Thought" (
"id" TEXT NOT NULL,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id            String     @id @default(uuid())

@@ -30,6 +31,8 @@ function App() {
<Route path="/signin" element={<Signin />} />
<Route path="/blogs" element={<Blogs />} />
<Route path="/blog/:id" element={<Blog />} />
<Route path="/thoughts" element={<Thought />} />

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line

@aadeshkulkarni aadeshkulkarni changed the title add feature:thought. (issue: #249) Feature | Thoughts Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounty 6$ | Feature | Thought
2 participants