Skip to content

Commit

Permalink
tests/kola: add space after ! in YAML architecture field
Browse files Browse the repository at this point in the history
The commit adds a space to all `kola` tests that use `!` to indicate the
negation semantic for architectures. This helps convey to users that the
`!` is distrubutive and not per element.
  • Loading branch information
lukewarmtemp authored and dustymabe committed Jul 31, 2023
1 parent 0a97993 commit eff3843
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion tests/kola/boot/grub2-install
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## tags: "platform-independent"
## # The test is not available for aarch64 and s390x,
## # as aarch64 is UEFI only and s390x is not using grub2
## architectures: "!aarch64 s390x"
## architectures: "! aarch64 s390x"
## description: Verify that we install BIOS/PReP bootloader
## using grub2-install from the target system.

Expand Down
2 changes: 1 addition & 1 deletion tests/kola/butane/grub-users/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## distros: fcos
## # coreos-post-ignition-checks.service forbids GRUB passwords on
## # ppc64le and s390x
## architectures: "!ppc64le s390x"
## architectures: "! ppc64le s390x"
## description: Verify that setting GRUB password works.

set -xeuo pipefail
Expand Down
2 changes: 1 addition & 1 deletion tests/kola/files/console-config
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
## exclusive: false
## # s390x doesn't have any configuration in platforms.yaml, so
## # platforms.json is not included in the image
## architectures: "!s390x"
## architectures: "! s390x"
## description: Verify that the kargs and grub.cfg commands specified in
## platforms.json have been properly applied to the image.

Expand Down
2 changes: 1 addition & 1 deletion tests/kola/networking/nic-naming
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
## kola:
## exclusive: false
## platforms: "!azure"
## platforms: "! azure"
## description: Verify that we detected eth* NIC naming after booted.

# Disable on azure because of a limitation of the hv_netvsc driver
Expand Down
2 changes: 1 addition & 1 deletion tests/kola/root-reprovision/luks/autosave-xfs/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## # Root reprovisioning requires at least 4GiB of memory.
## minMemory: 4096
## # A TPM backend device is not available on s390x to suport TPM.
## architectures: "!s390x"
## architectures: "! s390x"
## # This test includes a lot of disk I/O and needs a higher
## # timeout value than the default.
## timeoutMin: 15
Expand Down
2 changes: 1 addition & 1 deletion tests/kola/root-reprovision/luks/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## # Root reprovisioning requires at least 4GiB of memory.
## minMemory: 4096
## # A TPM backend device is not available on s390x to suport TPM.
## architectures: "!s390x"
## architectures: "! s390x"
## # This test includes a lot of disk I/O and needs a higher
## # timeout value than the default.
## timeoutMin: 15
Expand Down
2 changes: 1 addition & 1 deletion tests/kola/var-mount/luks/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## kola:
## # Restrict to qemu for now because the primary disk path is platform-dependent
## platforms: qemu
## architectures: "!s390x"
## architectures: "! s390x"
## description: Verify that reprovision disk with luks works.

set -xeuo pipefail
Expand Down

0 comments on commit eff3843

Please sign in to comment.