Fix flickering in pokemon storage system due to missed HBlank #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been using this branch for a couple of years and had complaints about occasional flickering with the palette swapping. It appears that sometimes for a frame or two a block of lines would use the wrong palettes. After line by line debugging, I found that occasionally the HBlank callback wouldn't run for some lines.
I added a variable to track the VCount on the previous HBlank and made the palette swap occur if the vertical line was passed, ensuring that it still swaps on every frame (even if it's off by a line). Haven't had any flickering since on both emulators and hardware.
Discord contact info
mostmodest