Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse additioanal error/warning info from lobster #323

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Parse additioanal error/warning info from lobster #323

merged 1 commit into from
Aug 16, 2024

Conversation

inferrna
Copy link
Contributor

@inferrna inferrna commented Aug 11, 2024 •
edited
Loading

Here link is clickable and follows to "help" definition in src/lib.lobster
image

also adds additional lines from output
image

@aardappel
Copy link
Owner

@ewoudje can you review?

@inferrna when you make a PR that includes TS, tag @ewoudje to alert him to a review.

@inferrna
Copy link
Contributor Author

So I 🧙 summon @ewoudje to review this pr

ewoudje
ewoudje approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ewoudje ewoudje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aardappel
Copy link
Owner

Thanks :)

@aardappel aardappel merged commit 70d538d into aardappel:master Aug 16, 2024
7 checks passed
@inferrna inferrna deleted the fix322 branch August 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoudje ewoudje ewoudje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inferrna @aardappel @ewoudje