Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add golanglintci precommit/gh action #37

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

wbollock
Copy link
Collaborator

Enforces good practice and standard linting. Will run in CI and pre-commit. Resolves all linter complaints too, just refactors.

Resolves: #36

enforce good practice and standard linting

Resolves: aarnaud#36
pkg/vault/client.go:104:19: SA1019: vault.Client.NewRenewer is deprecated: exists only for backwards compatibility. Calls NewLifetimeWatcher, and sets compatibility flags. (staticcheck)
		renewer, err := vault.Client.NewRenewer(&vaultapi.RenewerInput{
renames varaibles, package names, and adds a bunch of exported
function/type comments. just normal in-place linter refactors
@wbollock wbollock requested a review from aarnaud November 25, 2024 23:19
Copy link
Owner

@aarnaud aarnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, there were a lot of bad named variables

@wbollock wbollock merged commit 6a98a64 into aarnaud:master Nov 26, 2024
2 checks passed
@wbollock wbollock deleted the ci/golanglint branch November 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint with golanglintci
2 participants