-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seedable generate functions #26
Open
Nystik-gh
wants to merge
10
commits into
aatxe:stable
Choose a base branch
from
Nystik-gh:pull-request-add-seedable
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace HashMap with LinkedHashMap for deterministic insertion
Nystik-gh
changed the title
Add Seedable generate functions
Add seedable generate functions
Sep 5, 2022
Nystik-gh
force-pushed
the
pull-request-add-seedable
branch
from
September 5, 2022 22:54
5afeb6f
to
79094b6
Compare
when seeding use rand_chacha for reproducible output across platforms
I'd like this to be merged, as I'm also interested in this feature. How could I contribute to this happening? |
aatxe
approved these changes
Sep 16, 2023
The change looks fine to me, but we need to move the project over to GitHub Actions since it's still waiting for TravisCI which was killed long ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I need to be able to reproduce the same generation multiple times so I've implemented a way to seed the random number generator, or provide your own generator.
If there is interest in merging such functionality.
Add
rand::Rng
argument toStates
traitnext()
function.Rename
generate
togenerate_base
which now takes an argument that implementsrand::Rng
Rename
generate_from_token
togenerate_from_token_base
which now takes an argument that implementsrand::Rng
Add new
generate
andgenerate_from_token
functions that call the base functions withthread_rng()
.Add the following seedable generate functions
generate_with_seed(seed: u64)
generate_with_rng<R: rand::Rng>(rng: R)
generate_from_token_with_seed(token: T, seed: u64)
generate_from_token_with_rng<R: rand::Rng>(token: T, rng: R)
Implement linked-hash-map for predictable hashmap insertion.
Add "seedable" feature