-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added switch network method #22
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0298dfb
feat: added switch network method
sendra f472f2b
feat: walletlink and mew working
sendra 4045f8f
fix: cleaning the code
sendra c0b5958
fix: trying to fix button on click
sendra 1aa6353
fix: type
sakulstra 5b9c715
fix: removed some unused files
sendra d302123
fix: merged conflicts. removed mew
sendra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
declare module 'eth-provider'; | ||
declare module '@myetherwallet/mewconnect-web-client'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,21 +28,23 @@ | |
"@lingui/react": "^3.13.0", | ||
"@mui/icons-material": "latest", | ||
"@mui/material": "latest", | ||
"@myetherwallet/mewconnect-web-client": "^2.2.0-beta.16", | ||
"@toruslabs/torus-embed": "^1.19.0", | ||
"@walletconnect/web3-provider": "^1.7.1", | ||
"axios": "^0.25.0", | ||
"eth-provider": "^0.10.0", | ||
"ethereum-blockies-base64": "^1.0.2", | ||
"react-intl": "^5.24.3", | ||
"walletlink": "^2.4.0", | ||
"web3modal": "^1.9.5", | ||
"ethers": "^5.5.3", | ||
"graphql": "^16.2.0", | ||
"graphql-ws": "^5.5.5", | ||
"next": "latest", | ||
"react": "latest", | ||
"react-dom": "latest", | ||
"react-intl": "^5.24.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. react-intl is not needed anymore, please delete this dependency |
||
"reflect-metadata": "^0.1.13", | ||
"subscriptions-transport-ws": "^0.11.0" | ||
"subscriptions-transport-ws": "^0.11.0", | ||
"walletlink": "^2.4.0", | ||
"web3modal": "^1.9.5" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.16.7", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
This package increases bundle size quite a bit, has no types & broken dependencies ... it's just a mess:
MyEtherWallet/MEWconnect-web-client#106
as long as there isn't put more effort in maintaining the lib i think it should not be supported as is decreases the experience for all other users