Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for enchanced connection #50

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

kele6ra
Copy link

@kele6ra kele6ra commented Sep 5, 2023

Added capability of enhanced connection from extended features of ble5

@Apollon77
Copy link

@kele6ra DO you maybe have alink to the relevant specs?

Copy link

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi , it would be nice to have all cleanup/style changes in a separate commit

@kele6ra
Copy link
Author

kele6ra commented Sep 6, 2023

@kele6ra DO you maybe have alink to the relevant specs?

Hello, yes
https://www.bluetooth.org/DocMan/handlers/DownloadDoc.ashx?doc_id=521059
7.8.66 LE Extended Create Connection command
7.7.65.10 LE Enhanced Connection Complete event
There were issue with extended connection in noble and I understand that there is a handler in socket library. I made commands equals to the bluez stack and checked them from specification.
I have checked it with usb-hci dongle with Zephyr RTOS.

@kele6ra
Copy link
Author

kele6ra commented Sep 6, 2023

hi , it would be nice to have all cleanup/style changes in a separate commit

Hello, yes. I will remove style changes, sorry for it. I forget that setup styler for vsc before.

@Apollon77
Copy link

@kele6ra Fine to include the style changes ... just in a separate commit so that it can be reviewed easier

@kele6ra
Copy link
Author

kele6ra commented Sep 7, 2023

@kele6ra Fine to include the style changes ... just in a separate commit so that it can be reviewed easier

add style changes for cpp and h files

Copy link

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra check welcome , note you could have more cleanup in 2d patch feel free to improve , or we can merge it that way

@kele6ra
Copy link
Author

kele6ra commented Sep 8, 2023

Extra check welcome , note you could have more cleanup in 2d patch feel free to improve , or we can merge it that way

I have checked it during implementation (ubnutu 20) with some sensors with CodedPHY and my colleagues are checking it now
I will notify if we will find something

@Apollon77
Copy link

I plan to review against specs next days ... also to get a bit into that specs topic ... but if it works this is probably saying more. :-)

@rzr rzr merged commit fc46ba6 into abandonware:master Feb 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants