Prevent build upgrades and test Node.js 20 #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzr what about this long hanging PR? ... |
Closed
|
Please rebase |
|
done |
|
hi, |
|
SImply Sqash and merge please |
|
I am afraid I can't because of conflicts : "This branch cannot be rebased due to conflicts" you have to rebase your branch, if you can't I'll drop this PR and do the work my side |
|
I've rebased it and released thanks anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, we need to update thios (and most likely also the other packages afterwards). Python 3.12 breaks all older node-gy versions and so many issdues because these older versions are in npm bundled.
Only option I found is this.
@rzr Please review and lets merge this. We could bring it out as last line of the old verschioning schema, but in fcat we limit now nodejs 10+. WDYT?