2.10.17: bugfix ASSIGN (#1467)

abaplint · Sep 8, 2024 · b18d1a9 · b18d1a9
1 parent 0290fc8
commit b18d1a9
Show file tree

Hide file tree

Showing 9 changed files with 52 additions and 19 deletions.
diff --git a/.github/regression/regression.js b/.github/regression/regression.js
@@ -6,7 +6,7 @@ const childProcess = require("child_process");
 const repos = [
   {name: "abap-openapi/abap-openapi",           command: "npm test"},
   {name: "abapGit/abapGit",                     command: "npm run unit"},
-  {name: "dominikpanzer/cacamber-BDD-for-ABAP", command: "npm test"},
+//  {name: "dominikpanzer/cacamber-BDD-for-ABAP", command: "npm test"},
   {name: "heliconialabs/abap-opentelemetry",    command: "npm test"},
   {name: "heliconialabs/abap-protobuf",         command: "npm test"},
   {name: "larshp/abap-advent-2020",             command: "npm test"},

diff --git a/packages/cli/package-lock.json b/packages/cli/package-lock.json
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.10.16",
+  "version": "2.10.17",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,7 +26,7 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.10.16",
+    "@abaplint/transpiler": "^2.10.17",
     "@types/glob": "^8.1.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.7",

diff --git a/packages/runtime/package-lock.json b/packages/runtime/package-lock.json
diff --git a/packages/runtime/package.json b/packages/runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.10.16",
+  "version": "2.10.17",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",

diff --git a/packages/runtime/src/statements/assign.ts b/packages/runtime/src/statements/assign.ts
@@ -30,7 +30,13 @@ export function assign(input: IAssignInput) {
             input.dynamicSource = input.dynamicSource.dereference();
           } else {
             // @ts-ignore
-            input.dynamicSource = input.dynamicSource.get()[s.toLowerCase().replace(/[~\\/]/g, "$") as any];
+            const source = input.dynamicSource.get();
+            if (source === undefined) {
+              // @ts-ignore
+              abap.builtin.sy.get().subrc.set(4);
+              return;
+            }
+            input.dynamicSource = source[s.toLowerCase().replace(/[~\\/]/g, "$") as any];
           }
         }
       } else {

diff --git a/packages/transpiler/package-lock.json b/packages/transpiler/package-lock.json
diff --git a/packages/transpiler/package.json b/packages/transpiler/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler",
-  "version": "2.10.16",
+  "version": "2.10.17",
   "description": "Transpiler",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",

diff --git a/test/statements/assign.ts b/test/statements/assign.ts
@@ -802,4 +802,31 @@ START-OF-SELECTION.
     expect(abap.console.getTrimmed()).to.equal("5\n2");
   });
 
+  it("assign arrow obj", async () => {
+    const code = `
+CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    CLASS-METHODS bar IMPORTING i_source TYPE any.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD bar.
+    FIELD-SYMBOLS <attribute> TYPE any.
+    DATA attribute_name TYPE string.
+    attribute_name = 'i_source->DFSDF'.
+    ASSIGN (attribute_name) TO <attribute>.
+    WRITE / sy-subrc.
+  ENDMETHOD.
+ENDCLASS.
+
+START-OF-SELECTION.
+  FIELD-SYMBOLS <fs> TYPE REF TO lcl.
+  DATA obj TYPE REF TO lcl.
+  ASSIGN obj TO <fs>.
+  lcl=>bar( <fs> ).`;
+    const js = await run(code);
+    const f = new AsyncFunction("abap", js);
+    await f(abap);
+    expect(abap.console.getTrimmed()).to.equal("4");
+  });
+
 });