Add in_group and has_attribute policy functions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two policy functions. 1. in_group checks whether an Abbey user's identity is within a group 2. has_attribute checks whether an Abbey user has a custom attribute with a given value
jeffchao
requested changes
Nov 21, 2023
src/abbey/functions/in_group.rego
Outdated
| import future.keywords.in | ||
|
|
||
| in_group(group_name) := true if { | ||
| some group in data.system.abbey.group_memberships |
There was a problem hiding this comment.
@Koshroy-Abbey why the extra variable instead of group_name in data.system.abbey.group_memberships?
|
|
||
| import future.keywords.if | ||
|
|
||
| has_attribute(name, value) := true if { |
There was a problem hiding this comment.
Please add code comment to document what this function is supposed to be doing. Same for other functions.
jeffchao
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
LGTM.
Some nits, but looks good. Also, as a separate PR, would be good to add in GH Actions for CI check on the tests. https://www.openpolicyagent.org/docs/latest/policy-testing/
|
|
||
| import future.keywords.if | ||
|
|
||
| # Function which checks whether a user has a given attribute |
There was a problem hiding this comment.
nit: Add a period to show this is a complete thought and the new sentence (on the next line) begins.
There was a problem hiding this comment.
Same nits for other code comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two policy functions.
in_group checks whether an Abbey user's identity is within a group
has_attribute checks whether an Abbey user has a custom attribute with a given value