-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anthropic model support #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.DS_Store should be killed. Btw., they should be blocked by the .gitignore.
6fbb72a
to
eb1f549
Compare
@Char15Xu Should we add anthropic package to requirements.txt? |
will do |
@Char15Xu Nice. Let me know if this is ready for another review. |
@zenodflow Yes, this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit. But overall LGTM. Nice work!
libem/optimize/price.json already include information on Claude model with the correct naming. Once the PR is approved, i will move on to test anthropic model on abt-buy dataset. |
In this PR, we add support for claude 3.5 sonnet for #48
[TODO] run
make claude
to test if current implementation work as expected.