Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anthropic model support #86

Merged
merged 10 commits into from
Aug 31, 2024
Merged

Add anthropic model support #86

merged 10 commits into from
Aug 31, 2024

Conversation

Char15Xu
Copy link
Collaborator

@Char15Xu Char15Xu commented Aug 10, 2024

In this PR, we add support for claude 3.5 sonnet for #48

[TODO] run make claude to test if current implementation work as expected.

@zenodflow zenodflow added the feat label Aug 10, 2024
@zenodflow zenodflow self-requested a review August 10, 2024 02:08
Copy link
Contributor

@zenodflow zenodflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.DS_Store should be killed. Btw., they should be blocked by the .gitignore.

Makefile Outdated Show resolved Hide resolved
@Char15Xu Char15Xu force-pushed the feat-claude branch 2 times, most recently from 6fbb72a to eb1f549 Compare August 13, 2024 06:58
@zenodflow zenodflow added the lgtm label Aug 20, 2024
@zenodflow
Copy link
Contributor

@Char15Xu Should we add anthropic package to requirements.txt?

@Char15Xu
Copy link
Collaborator Author

@Char15Xu Should we add anthropic package to requirements.txt?

will do

@zenodflow
Copy link
Contributor

@Char15Xu Nice. Let me know if this is ready for another review.

@Char15Xu
Copy link
Collaborator Author

@zenodflow Yes, this is ready for review

cli/libem Outdated Show resolved Hide resolved
cli/libem Outdated Show resolved Hide resolved
Copy link
Contributor

@zenodflow zenodflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit. But overall LGTM. Nice work!

@Char15Xu
Copy link
Collaborator Author

libem/optimize/price.json already include information on Claude model with the correct naming. Once the PR is approved, i will move on to test anthropic model on abt-buy dataset.

@zenodflow zenodflow changed the title Add anthropic model support, testing needed Add anthropic model support Aug 29, 2024
@zenodflow zenodflow merged commit 2045be3 into abcsys:main Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants