fix(cli): preserve Literal type for mode in command dispatch#49
Open
Flames4fun wants to merge 1 commit intoabduznik:masterfrom
Open
fix(cli): preserve Literal type for mode in command dispatch#49Flames4fun wants to merge 1 commit intoabduznik:masterfrom
Flames4fun wants to merge 1 commit intoabduznik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
mypyerrors reported insrc/cli.pyby preserving the narrow literal type used for command dispatch mode.What changed
Modetype alias asLiteral["fast", "smart"]modewith an explicit branch assignmentWhy
The previous implementation assigned
modeusing a conditional expression, which causedmypyto widen the inferred type more than expected in this context. Several command handlers requireLiteral["fast", "smart"], so the type mismatch surfaced as multiple static type errors insrc/cli.py.Using an explicit branch preserves the intended literal typing cleanly and avoids adding unnecessary casts.
Validation