-
Notifications
You must be signed in to change notification settings - Fork 1
Achromatic spectrometer #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
feliponelguapon
wants to merge
13
commits into
main
Choose a base branch
from
achromatic_spectrometer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7ddd204
Added an achromatic spectrometer class. ALso updated the plasma_lens_…
feliponelguapon aff853c
Added a new source that produces bunches where the particles have dis…
feliponelguapon 7a01c69
Added a property 'l' for convenience that returns the length of the p…
feliponelguapon f8b2864
Added the possibility to edit the plot in plot_transverse_profile
feliponelguapon 47282f6
Added the SourceEnergyComb in the __init__ file.
feliponelguapon 9f86936
Allows to use Experiment() class without a component, e.g., just a so…
feliponelguapon 61404d8
Added documentation to the new files
feliponelguapon 29c55ab
Revert "Added the possibility to edit the plot in plot_transverse_pro…
kyrsjo 7cc40dc
Re-add the actual changes that was done in the whitespace-deletion-co…
kyrsjo c849d1f
Merge pull request #51 from carlandreaslindstrom/acromatic_spectromet…
feliponelguapon 2288228
Merge branch 'main' into achromatic_spectrometer
feliponelguapon 680d785
Updated documentation
feliponelguapon 1ffafea
Found a typo
feliponelguapon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of a "thick" plasma lens, where the beam position in the lens changes significantly as the particle passes through the lens, it is probably needed to have several slices. This is the case at CLEAR due to low beam energy.
I would strongly recommend to have a parameter for setting the number of kicks used to track, i.e. for approximating the change of position and momentum on the particles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For quads there is some literature for how to optimally slice, I think this is a good reference:
https://cds.cern.ch/record/165372/files/p35.pdf
The TEAPOT algorithm is implemented in MadX's MAKETHIN command if I remember correctly. There has probably also been updates by Helmut Burkhardt since TEAPOT was originally written - I think there is an IPAC paper somewhere at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However as a first go, I would just add a loop over the number of slices N, then for each slice do
where the drift length is L/N and the kick integral length is also L/N.
One can be slightly more clever and combine the "abutting" drifts, for slightly better performance, but I doubt it matters.
I implented something like this here, for JT model:
https://gitlab.cern.ch/CLEAR/CLEAR_DAN/-/blob/master/utilities/tracking_thick_JT.m?ref_type=heads#L79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is this somewhat overlapping with what @Hektor1201 is working on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the idea is that Felipe does this simple one first, and then we switch it to using Hektor’s thick-lens implementation when that is ready. In the meantime, Felipe implements the achromatic spectrometer also in ImpactX.