fixes/Resolve PR comments

- merge test methods to one - resolve blank spaces - change description
abhaynikam · Jun 27, 2023 · 539b0c2 · 539b0c2
1 parent 8c3f4ca
commit 539b0c2
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/.gitignore b/.gitignore
@@ -10,4 +10,4 @@
 .byebug_history
 
 *.log
-.idea
+.idea
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -143,4 +143,5 @@ DEPENDENCIES
   sqlite3 (~> 1.4)
 
 BUNDLED WITH
-   2.4.10
+   2.4.10
+
diff --git a/lib/generators/boring/whenever/install/install_generator.rb b/lib/generators/boring/whenever/install/install_generator.rb
@@ -3,7 +3,7 @@
 module Boring
   module Whenever
     class InstallGenerator < Rails::Generators::Base
-      desc "Adds whenever gem to the application"
+      desc "Adds whenever gem to the application for managing cron jobs"
 
       def add_whenever_gem
         say "Adding whenever gem", :green

diff --git a/test/generators/whenever_install_generator_test.rb b/test/generators/whenever_install_generator_test.rb
@@ -15,18 +15,11 @@ def destination_root
     app_path
   end
 
-  def test_should_install_whenever_gem
-    Dir.chdir(app_path) do
-      quietly { generator.add_whenever_gem }
-
-      assert_gem "whenever"
-    end
-  end
-
-  def test_should_configure_whenever
+  def test_should_configure_whenever_gem
     Dir.chdir(app_path) do
       quietly { run_generator }
 
+      assert_gem "whenever"
       assert_file "config/schedule.rb"
     end
   end
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,4 +10,4 @@ @@
     .byebug_history
     *.log
-    .idea
+    .idea