Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implements the every-at cron syntax #45

Merged
merged 16 commits into from
Feb 23, 2024

Conversation

barino86
Copy link

This would close out the #44 issue that I created the other day.

@abichinger
Copy link
Owner

Hello @barino86,

thank you for the PR. It seems like crontab does not support this syntax so I would prefer if this feature was disabled by default.

Which schedular are you using?

package.json Outdated Show resolved Hide resolved
@barino86
Copy link
Author

We are using a kind of home-grown scheduler. We use this library in the UI of our application to help end users build the cron expressions they need, then we use a python library croniter to determine the next scheduled date time based on the cron expression.

@barino86
Copy link
Author

How would you like me to turn it off by default, possibly have a prop that can enable it?

@abichinger
Copy link
Owner

Yeah, a boolean prop would be good.

@barino86
Copy link
Author

Let me know if there is a different way you would like to see this implemented.

@barino86
Copy link
Author

Oops, going to fix the test.

@barino86
Copy link
Author

Fixed.

@barino86
Copy link
Author

I want to make that prop more dynamic by adding a watch and setting it so that it can be changed on the fly if it needs to be. working on the change for that.

@barino86
Copy link
Author

Prop is now dynamic and has been added to light and vuetify as well. I think this is ready once you call it good.

@abichinger
Copy link
Owner

Looks good. Thank you for your contribution.

@abichinger abichinger merged commit 4c9f33c into abichinger:vue2 Feb 23, 2024
2 checks passed
@barino86
Copy link
Author

Thank you for being open to a new feature on an older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants