Skip to content

Commit

Permalink
Merge pull request #168 from ably/rename-finish-to-unsubscribe
Browse files Browse the repository at this point in the history
Rename Subscription’s `finish` method to `unsubscribe`
  • Loading branch information
lawrence-forooghian authored Dec 4, 2024
2 parents 5ea07db + 501a1d5 commit e017c72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Sources/AblyChat/Subscription.swift
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public struct Subscription<Element: Sendable>: Sendable, AsyncSequence {
}

// TODO: https://github.com/ably-labs/ably-chat-swift/issues/36 Revisit how we want to unsubscribe to fulfil CHA-M4b & CHA-ER4b. I think exposing this publicly for all Subscription types is suitable.
public func finish() {
public func unsubscribe() {
switch mode {
case let .default(_, continuation):
continuation.finish()
Expand Down

0 comments on commit e017c72

Please sign in to comment.