[ECO-4927] Change Metadata to use JSONValue
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec isn’t explicit about the type (have created [1] for this to be clarified), but from the examples given there, it seems that it can be any JSON `object`. Part of #13. [1] ably/specification#260
lawrence-forooghian
force-pushed
the
13-fix-metadata-type
branch
from
c84b73a to
360d7c3
Compare
4 tasks
umair-ably
approved these changes
Dec 18, 2024
maratal
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #201; please review that one first.
The spec isn’t explicit about the type (have created ably/specification#260 for this to be clarified), but from the examples given there, it seems that it can be any JSON
object.Part of #13.