-
Notifications
You must be signed in to change notification settings - Fork 7
[ECO-5126] Connection tests #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
2b1468e to
19e7c44
Compare
1f0e133 to
de514e1
Compare
124b2a4 to
e7ddf4b
Compare
e7ddf4b to
e41cfeb
Compare
e41cfeb to
e63ff82
Compare
e63ff82 to
50f0ded
Compare
50f0ded to
b40c1d4
Compare
b40c1d4 to
32a52ec
Compare
|
A note that we might be getting rid of the "transient disconnect" handling in Chat (see this proposal), which would mean that basically the chat |
…ncSequence`. AsyncSequence API left as a convenience and is used in tests. Update example app to use callbacks.
…x/235-messages-tests # Conflicts: # Tests/AblyChatTests/Mocks/MockRoomLifecycleManager.swift
4db48ee to
c071197
Compare
32a52ec to
78ab16b
Compare
016d94c to
bef8992
Compare
2b1785d to
726e936
Compare
7ba9745 to
e92fc1d
Compare
e92fc1d to
458585a
Compare
Closes #124