Skip to content

Conversation

@maratal
Copy link
Collaborator

@maratal maratal commented Apr 6, 2025

Closes #124

@coderabbitai
Copy link

coderabbitai bot commented Apr 6, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@maratal maratal changed the base branch from main to fix/235-reactions-tests April 6, 2025 21:15
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 6, 2025 21:16 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from 2b1468e to 19e7c44 Compare April 6, 2025 22:23
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 6, 2025 22:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 6, 2025 22:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 6, 2025 23:18 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from 1f0e133 to de514e1 Compare April 9, 2025 11:43
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 11:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 11:55 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from 124b2a4 to e7ddf4b Compare April 9, 2025 11:59
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 12:00 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from e7ddf4b to e41cfeb Compare April 9, 2025 12:04
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 12:05 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from e41cfeb to e63ff82 Compare April 9, 2025 12:17
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 12:18 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from e63ff82 to 50f0ded Compare April 9, 2025 12:25
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 12:26 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from 50f0ded to b40c1d4 Compare April 9, 2025 12:52
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 12:53 Inactive
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from b40c1d4 to 32a52ec Compare April 9, 2025 13:09
@github-actions github-actions bot temporarily deployed to staging/pull/263/AblyChat April 9, 2025 13:10 Inactive
@lawrence-forooghian
Copy link
Collaborator

A note that we might be getting rid of the "transient disconnect" handling in Chat (see this proposal), which would mean that basically the chat Connection would just become a wrapper around the ably-cocoa one. So I would suggest pausing this PR for now until that proposal is decided.

maratal added 5 commits May 17, 2025 23:06
…ncSequence`.

AsyncSequence API left as a convenience and is used in tests.
Update example app to use callbacks.
…x/235-messages-tests

# Conflicts:
#	Tests/AblyChatTests/Mocks/MockRoomLifecycleManager.swift
@maratal maratal force-pushed the fix/235-reactions-tests branch from 4db48ee to c071197 Compare May 23, 2025 15:53
@maratal maratal force-pushed the fix/124-connection-tests-v2 branch from 32a52ec to 78ab16b Compare May 24, 2025 20:57
@maratal maratal force-pushed the fix/235-reactions-tests branch 2 times, most recently from 016d94c to bef8992 Compare May 25, 2025 10:54
@lawrence-forooghian lawrence-forooghian force-pushed the fix/235-reactions-tests branch 2 times, most recently from 2b1785d to 726e936 Compare June 12, 2025 20:49
@maratal maratal force-pushed the fix/235-reactions-tests branch 2 times, most recently from 7ba9745 to e92fc1d Compare June 28, 2025 23:00
@maratal maratal force-pushed the fix/235-reactions-tests branch from e92fc1d to 458585a Compare June 30, 2025 19:20
Base automatically changed from fix/235-reactions-tests to main June 30, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for Connection

3 participants