Skip to content

Commit

Permalink
Merge pull request #66 from ably/feature/pub-feedback
Browse files Browse the repository at this point in the history
Feature/pub feedback
  • Loading branch information
QuintinWillison authored Nov 17, 2020
2 parents 7e406a3 + 71448e6 commit 8846c4b
Show file tree
Hide file tree
Showing 18 changed files with 73 additions and 79 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.0.0+dev.2](https://github.com/ably/ably-flutter/tree/1.0.0-dev.2)

Conforming to pub.dev recommendations, following initial upload to the platform.

## [1.0.0+dev.1](https://github.com/ably/ably-flutter/tree/1.0.0-dev.1)

The first, development preview of our Flutter plugin, wrapping our
Expand Down
10 changes: 5 additions & 5 deletions example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ packages:
path: ".."
relative: true
source: path
version: "1.0.0+dev.1"
version: "1.0.0+dev.2"
async:
dependency: transitive
description:
Expand Down Expand Up @@ -101,7 +101,7 @@ packages:
name: meta
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.0-nullsafety.3"
version: "1.3.0-nullsafety.4"
path:
dependency: transitive
description:
Expand All @@ -115,7 +115,7 @@ packages:
name: pedantic
url: "https://pub.dartlang.org"
source: hosted
version: "1.8.0+1"
version: "1.9.2"
sky_engine:
dependency: transitive
description: flutter
Expand All @@ -134,7 +134,7 @@ packages:
name: stack_trace
url: "https://pub.dartlang.org"
source: hosted
version: "1.10.0-nullsafety.1"
version: "1.10.0-nullsafety.2"
stream_channel:
dependency: transitive
description:
Expand Down Expand Up @@ -178,5 +178,5 @@ packages:
source: hosted
version: "2.1.0-nullsafety.3"
sdks:
dart: ">=2.10.0-110 <2.11.0"
dart: ">=2.10.0-110 <=2.11.0-213.1.beta"
flutter: ">=1.17.0 <2.0.0"
4 changes: 2 additions & 2 deletions lib/src/codec.dart
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import 'package:ably_flutter_plugin/src/generated/platformconstants.dart';
import 'package:ably_flutter_plugin/src/impl/message.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';

import '../ably_flutter_plugin.dart';
import '../src/generated/platformconstants.dart';
import '../src/impl/message.dart';


/// a [_Encoder] encodes custom type and converts it to a Map which will
Expand Down
4 changes: 2 additions & 2 deletions lib/src/impl/platform_object.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import 'dart:async';

import 'package:ably_flutter_plugin/src/impl/message.dart';
import 'package:ably_flutter_plugin/src/platform.dart' as platform;
import 'package:flutter/services.dart';
import 'package:meta/meta.dart';

import '../platform.dart' as platform;
import 'message.dart';
import 'streams_channel.dart';

/// An object which has a live counterpart in the Platform client library SDK,
Expand Down
8 changes: 4 additions & 4 deletions lib/src/impl/realtime/channels.dart
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import 'dart:async';
import 'dart:collection';

import 'package:ably_flutter_plugin/ably_flutter_plugin.dart';
import 'package:ably_flutter_plugin/src/impl/realtime/realtime.dart';
import 'package:ably_flutter_plugin/src/spec/push/channels.dart';
import 'package:ably_flutter_plugin/src/spec/spec.dart' as spec;
import 'package:flutter/services.dart';
import 'package:pedantic/pedantic.dart';

import '../../../ably_flutter_plugin.dart';
import '../../spec/push/channels.dart';
import '../../spec/spec.dart' as spec;
import '../platform_object.dart';
import 'realtime.dart';

class RealtimePlatformChannel extends PlatformObject
implements spec.RealtimeChannel {
Expand Down
5 changes: 2 additions & 3 deletions lib/src/impl/realtime/connection.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import 'dart:async';

import 'package:ably_flutter_plugin/ably_flutter_plugin.dart';
import 'package:ably_flutter_plugin/src/impl/realtime/realtime.dart';

import '../../../ably_flutter_plugin.dart';
import '../../spec/spec.dart' show Connection, ConnectionState, ErrorInfo;
import '../platform_object.dart';
import 'realtime.dart';

class ConnectionPlatformObject extends PlatformObject implements Connection {
Realtime realtimePlatformObject;
Expand Down
4 changes: 2 additions & 2 deletions lib/src/impl/realtime/realtime.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import 'dart:async';
import 'dart:collection';

import 'package:ably_flutter_plugin/src/impl/message.dart';
import 'package:ably_flutter_plugin/src/impl/realtime/channels.dart';
import 'package:pedantic/pedantic.dart';

import '../../../ably_flutter_plugin.dart';
import '../../spec/spec.dart' as spec;
import '../message.dart';
import '../platform_object.dart';
import 'channels.dart';
import 'connection.dart';

Map<int, Realtime> _realtimeInstances = {};
Expand Down
6 changes: 3 additions & 3 deletions lib/src/impl/rest/channels.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import 'dart:async';
import 'dart:collection';

import 'package:ably_flutter_plugin/ably_flutter_plugin.dart';
import 'package:ably_flutter_plugin/src/impl/rest/rest.dart';
import 'package:ably_flutter_plugin/src/spec/spec.dart' as spec;
import 'package:flutter/services.dart';
import 'package:pedantic/pedantic.dart';

import '../../../ably_flutter_plugin.dart';
import '../../spec/spec.dart' as spec;
import '../platform_object.dart';
import 'rest.dart';

class RestPlatformChannel extends PlatformObject implements spec.RestChannel {
/// [Rest] instance
Expand Down
3 changes: 1 addition & 2 deletions lib/src/impl/rest/rest.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import 'dart:async';
import 'dart:collection';

import 'package:ably_flutter_plugin/src/impl/message.dart';

import '../../../ably_flutter_plugin.dart';
import '../../spec/spec.dart' as spec;
import '../message.dart';
import '../platform_object.dart';
import 'channels.dart';

Expand Down
2 changes: 1 addition & 1 deletion lib/src/info.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:ably_flutter_plugin/src/generated/platformconstants.dart' show PlatformMethod;
import 'generated/platformconstants.dart' show PlatformMethod;

import 'platform.dart' show invoke;

Expand Down
7 changes: 4 additions & 3 deletions lib/src/method_call_handler.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import 'package:ably_flutter_plugin/ably_flutter_plugin.dart' as ably;
import 'package:ably_flutter_plugin/src/generated/platformconstants.dart';
import 'package:ably_flutter_plugin/src/impl/message.dart';
import 'package:flutter/services.dart';

import '../ably_flutter_plugin.dart' as ably;
import 'generated/platformconstants.dart';
import 'impl/message.dart';

class AblyMethodCallHandler {
AblyMethodCallHandler(MethodChannel channel) {
channel.setMethodCallHandler((call) async {
Expand Down
4 changes: 2 additions & 2 deletions lib/src/platform.dart
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import 'dart:async';

import 'package:ably_flutter_plugin/src/generated/platformconstants.dart' show PlatformMethod;
import 'package:ably_flutter_plugin/src/method_call_handler.dart';
import 'package:flutter/services.dart';

import 'codec.dart';
import 'generated/platformconstants.dart' show PlatformMethod;
import 'impl/streams_channel.dart';
import 'method_call_handler.dart';


/// instance of [StandardMethodCodec] with custom [MessageCodec] for
Expand Down
7 changes: 3 additions & 4 deletions lib/src/spec/realtime/channels.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import 'package:ably_flutter_plugin/src/spec/push/channels.dart';
import 'package:ably_flutter_plugin/src/spec/rest/ably_base.dart';
import 'package:ably_flutter_plugin/src/spec/rest/channels.dart';

import '../common.dart';
import '../enums.dart';
import '../message.dart';
import '../push/channels.dart';
import '../rest/ably_base.dart';
import '../rest/channels.dart';
import 'presence.dart';


Expand Down
2 changes: 0 additions & 2 deletions lib/src/spec/rest/channels.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'package:ably_flutter_plugin/src/spec/rest/ably_base.dart';

import '../common.dart';
import '../message.dart';
import 'ably_base.dart';
Expand Down
3 changes: 1 addition & 2 deletions lib/src/spec/rest/options.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import 'package:ably_flutter_plugin/ably_flutter_plugin.dart';

import '../../../ably_flutter_plugin.dart';
import '../common.dart';
import '../enums.dart';

Expand Down
Loading

0 comments on commit 8846c4b

Please sign in to comment.