Use TransportName values when setting transports’ shortName

Preparation for #1394 (making transports tree-shakable).
ably · Nov 7, 2023 · da87214 · da87214
1 parent 336bc9c
commit da87214
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/common/lib/transport/websockettransport.ts b/src/common/lib/transport/websockettransport.ts
@@ -8,8 +8,9 @@ import ErrorInfo from '../types/errorinfo';
 import NodeWebSocket from 'ws';
 import ConnectionManager, { TransportParams } from './connectionmanager';
 import Auth from '../client/auth';
+import TransportName from 'common/constants/TransportName';
 
-const shortName = 'web_socket';
+const shortName = TransportName.WebSocket;
 
 function isNodeWebSocket(ws: WebSocket | NodeWebSocket): ws is NodeWebSocket {
   return !!(ws as NodeWebSocket).on;

diff --git a/src/platform/nodejs/lib/transport/nodecomettransport.js b/src/platform/nodejs/lib/transport/nodecomettransport.js
@@ -10,10 +10,11 @@ import http from 'http';
 import https from 'https';
 import url from 'url';
 import util from 'util';
+import TransportName from '../../../../common/constants/TransportName';
 
 var NodeCometTransport = function (connectionManager) {
   var noop = function () {};
-  var shortName = 'comet';
+  var shortName = TransportName.Comet;
 
   /*
    * A transport to use with nodejs

diff --git a/src/platform/web/lib/transport/xhrpollingtransport.ts b/src/platform/web/lib/transport/xhrpollingtransport.ts
@@ -4,8 +4,9 @@ import XHRRequest from './xhrrequest';
 import ConnectionManager, { TransportParams } from 'common/lib/transport/connectionmanager';
 import Auth from 'common/lib/client/auth';
 import { RequestParams } from 'common/types/http';
+import TransportName from 'common/constants/TransportName';
 
-var shortName = 'xhr_polling';
+var shortName = TransportName.XhrPolling;
 class XHRPollingTransport extends CometTransport {
   shortName = shortName;
   constructor(connectionManager: ConnectionManager, auth: Auth, params: TransportParams) {

diff --git a/src/platform/web/lib/transport/xhrstreamingtransport.ts b/src/platform/web/lib/transport/xhrstreamingtransport.ts
@@ -4,8 +4,9 @@ import XHRRequest from './xhrrequest';
 import ConnectionManager, { TransportParams } from 'common/lib/transport/connectionmanager';
 import Auth from 'common/lib/client/auth';
 import { RequestParams } from 'common/types/http';
+import TransportName from 'common/constants/TransportName';
 
-const shortName = 'xhr_streaming';
+const shortName = TransportName.XhrStreaming;
 class XHRStreamingTransport extends CometTransport {
   shortName = shortName;
   constructor(connectionManager: ConnectionManager, auth: Auth, params: TransportParams) {