Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tree-shakable transport modules #1394

Closed
owenpearson opened this issue Jul 18, 2023 · 2 comments
Closed

Create tree-shakable transport modules #1394

owenpearson opened this issue Jul 18, 2023 · 2 comments
Assignees
@lawrence-forooghian

Comments

@owenpearson
Copy link
Member

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 18, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3733

@lawrence-forooghian lawrence-forooghian mentioned this issue Aug 3, 2023
Merged
@lawrence-forooghian lawrence-forooghian self-assigned this Aug 23, 2023
lawrence-forooghian added a commit that referenced this issue Aug 29, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
c9c327f 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Aug 29, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
17902d0 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Aug 29, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
ff2402c 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Aug 29, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
544f03c 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Aug 29, 2023
@lawrence-forooghian
Make transports tree-shakable
98cfdb1 
TODO test

TODO understand why bundle size not being decreased

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Aug 31, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
fe1add1 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Aug 31, 2023
@lawrence-forooghian
Make transports tree-shakable
7f19222 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
@lawrence-forooghian lawrence-forooghian mentioned this issue Aug 31, 2023
Merged
lawrence-forooghian added a commit that referenced this issue Aug 31, 2023
@lawrence-forooghian
Make transports tree-shakable
ad4f6a3 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Sep 5, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
4ba7954 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 5, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
d29233f 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 5, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
a62db08 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 5, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
9239dea 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 5, 2023
@lawrence-forooghian
Make transports tree-shakable
14424f1 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Sep 14, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
a5be06f 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 14, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
5640221 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 14, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
9ee0695 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 14, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
7cb13b9 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Sep 14, 2023
@lawrence-forooghian
Make transports tree-shakable
1feb6e3 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Make transports tree-shakable
23c83d9 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
a0a4632 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
d6cf92e 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
91e8d53 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
b6331e2 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Make transports tree-shakable
b66c87b 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
951d5b0 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
cd34015 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
bab45f2 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Make transports tree-shakable
b5bd09d 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
339b70b 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
07e8dd7 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
e121192 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
dbeab32 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Make transports tree-shakable
d2d5199 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian
Make transports tree-shakable
1c61527 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Nov 7, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
7d6d607 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 7, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
da87214 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 7, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
e289fc1 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 7, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
719cf24 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 7, 2023
@lawrence-forooghian
Make transports tree-shakable
57a6e8d 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
37a2841 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
0d2fc3d 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
2640309 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
654cb78 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Make transports tree-shakable
21d387c 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
ad501e9 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
010fe29 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
7ab6601 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
0bbcf9f 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 8, 2023
@lawrence-forooghian
Make transports tree-shakable
d986ea2 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
lawrence-forooghian added a commit that referenced this issue Nov 14, 2023
@lawrence-forooghian
Extract type of IPlatform.Transports
ebbb354 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 14, 2023
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
a0df5f5 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 14, 2023
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
8d4e477 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 14, 2023
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
57c09f6 
Preparation for #1394 (making transports tree-shakable).
lawrence-forooghian added a commit that referenced this issue Nov 14, 2023
@lawrence-forooghian
Make transports tree-shakable
d7f9bd5 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
@lawrence-forooghian
Copy link
Collaborator

Closed in #1432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owenpearson @lawrence-forooghian