Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't double url encode agent transport param #1462

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: don't double url encode agent transport param #1462

merged 1 commit into from
Oct 19, 2023

Conversation

owenpearson
Copy link
Member

@owenpearson owenpearson commented Oct 12, 2023 •
edited
Loading

This was never needed - encoding the connect params is the responsibility of each individual transport and the transports already do this.

@owenpearson owenpearson marked this pull request as ready for review October 17, 2023 10:02
ttypic
ttypic approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@owenpearson owenpearson merged commit 0d7dd24 into main Oct 19, 2023
@owenpearson owenpearson deleted the fix-double-encoded-agent branch October 19, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@lawrence-forooghian lawrence-forooghian Awaiting requested review from lawrence-forooghian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenpearson @ttypic