Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid directly exporting Ably.ErrorInfo from promises.js #1463

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: avoid directly exporting Ably.ErrorInfo from promises.js #1463

merged 1 commit into from
Oct 19, 2023

Conversation

owenpearson
Copy link
Member

For confusing reasons, this commit introduced a regression which changed the behaviour of ESM imports of promises.js, and this change fixes it.

@owenpearson owenpearson marked this pull request as ready for review October 19, 2023 12:08
@owenpearson owenpearson merged commit 374252c into main Oct 19, 2023
@owenpearson owenpearson deleted the fix-errorinfo-promise-export branch October 19, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@lawrence-forooghian lawrence-forooghian Awaiting requested review from lawrence-forooghian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenpearson @ttypic