[SDK-3920] Add a basic test of NPM package #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
3bb9c0f to
ca02abe
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
ca02abe to
761fb79
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
761fb79 to
0962572
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
0962572 to
9670996
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
lawrence-forooghian
force-pushed
the
1474-package-test
branch
2 times, most recently
from
721c203 to
ed0aea1
Compare
lawrence-forooghian
changed the base branch from
integration/v2
to
1397-tree-shakable-MessageInteractions
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
ed0aea1 to
58905ff
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
lawrence-forooghian
force-pushed
the
1397-tree-shakable-MessageInteractions
branch
from
7c379cf to
53cafd4
Compare
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
9f3dabb to
0cca628
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
lawrence-forooghian
force-pushed
the
1397-tree-shakable-MessageInteractions
branch
from
53cafd4 to
5c54465
Compare
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
0cca628 to
d6902d0
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1476/features
github-actions
bot
temporarily deployed
to
staging/pull/1476/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1476/bundle-report
owenpearson
requested changes
Nov 14, 2023
lawrence-forooghian
force-pushed
the
1397-tree-shakable-MessageInteractions
branch
from
5c54465 to
6a96472
Compare
When using this function to run `tsc`, noticed that it wasn’t outputting any useful information about why that command failed, because all of the error information was going to stdout.
This adds a package script `test:package`, which performs some basic testing to confirm that a browser-based TypeScript app is able to import the NPM package and use Ably functionality. This hopefully gives us further confidence that we’ve correctly configured the package’s exports and typings. Next, we’ll build on top of this to add similar testing for the tree-shakable version of the library, once we’ve added typings for it in #1442. Some of the approach here is copied from that used for testing the CDN bundle in the Spaces SDK (see commit fa95f9f there). Resolves #1474.
lawrence-forooghian
force-pushed
the
1474-package-test
branch
from
d6902d0 to
9976a84
Compare
owenpearson
approved these changes
Nov 20, 2023
Base automatically changed from
1397-tree-shakable-MessageInteractions
to
1395-http-tree-shaking
November 21, 2023 00:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #1473; please review that one first.
This adds a package script
test:package, which performs some basic testing to confirm that a browser-based TypeScript app is able to import the NPM package and use Ably functionality.This hopefully gives us further confidence that we’ve correctly configured the package’s exports and typings. Next, we’ll build on top of this to add similar testing for the tree-shakable version of the library, once we’ve added typings for it in #1442.
Some of the approach here is copied from that used for testing the CDN bundle in the Spaces SDK.
Resolves #1474.