Remove static stuff from *Message classes
#1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1503/features
github-actions
bot
temporarily deployed
to
staging/pull/1503/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1503/typedoc
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
cce7de2 to
4ae8580
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1503/features
github-actions
bot
temporarily deployed
to
staging/pull/1503/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1503/bundle-report
owenpearson
reviewed
Nov 22, 2023
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
4ae8580 to
b59bd66
Compare
|
@owenpearson I've just pushed a change to fix a typo in a comment. |
github-actions
bot
temporarily deployed
to
staging/pull/1503/features
github-actions
bot
temporarily deployed
to
staging/pull/1503/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1503/typedoc
lawrence-forooghian
force-pushed
the
1443-add-documentation-for-tree-shakable-version
branch
2 times, most recently
from
72ba373 to
d750acd
Compare
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
b59bd66 to
3b881f8
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1503/features
github-actions
bot
temporarily deployed
to
staging/pull/1503/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1503/typedoc
lawrence-forooghian
force-pushed
the
1443-add-documentation-for-tree-shakable-version
branch
from
d750acd to
48ede7f
Compare
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
3b881f8 to
ed5ff7d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1503/features
github-actions
bot
temporarily deployed
to
staging/pull/1503/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1503/typedoc
Base automatically changed from
1443-add-documentation-for-tree-shakable-version
to
integration/v2
November 24, 2023 18:10
And define it more simply.
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
ed5ff7d to
c09cee7
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1503/features
github-actions
bot
temporarily deployed
to
staging/pull/1503/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1503/typedoc
Replace them by standalone exports, which can be tree-shaken. (My eye was in particular caught by the Message.encrypt function, which I was thinking it would be good to — at some point — bundle only if the Crypto module is used. This change isn’t made here though.)
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
c09cee7 to
875282c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #1443; please review that one first.
Replace them by standalone exports, which can be tree-shaken.
(My eye was in particular caught by the
Message.encryptfunction, which I was thinking it would be good to — at some point — bundle only if theCryptomodule is used. This change isn’t made here though.)