Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.6.3 #1962

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Release/2.6.3 #1962

merged 2 commits into from
Jan 28, 2025

Conversation

ttypic
Copy link
Collaborator

@ttypic ttypic commented Jan 24, 2025

  • Fixed useChannel hook can throw exception in the effect if connection is closed #1938

Summary by CodeRabbit

@ttypic ttypic requested a review from VeskeR January 24, 2025 13:14
Copy link

coderabbitai bot commented Jan 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces version 2.6.3 of the Ably JavaScript library, focusing on addressing issues with the useChannel hook in React. The changes include updating the version number across multiple files (CHANGELOG.md, package.json, and AblyReactHooks.ts) and preparing for handling exceptions when the connection is closed during channel interactions. Additionally, the FetchRequest now respects the disableConnectivityCheck client option.

Changes

File Change Summary
CHANGELOG.md Added version 2.6.3 entry describing fixes for useChannel hook, FetchRequest, and RealtimeChannel.modes
package.json Updated version from 2.6.2 to 2.6.3
src/platform/react-hooks/src/AblyReactHooks.ts Updated version constant from '2.6.2' to '2.6.3'

Assessment against linked issues

Objective Addressed Explanation
Handle exception when connection is closed in useChannel hook [#1938]
Respect disableConnectivityCheck option in FetchRequest [#1925]

Possibly related PRs

Suggested reviewers

  • AndyTWF

Poem

🐰 A rabbit's tale of version might,
Code hopping to version two-point-six-three's light!
Hooks fixed with care, exceptions now tamed,
In Ably's realm, another milestone claimed! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2425691 and 59da423.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot temporarily deployed to staging/pull/1962/bundle-report January 24, 2025 13:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/features January 24, 2025 13:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/typedoc January 24, 2025 13:14 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ttypic ttypic requested a review from VeskeR January 24, 2025 13:39
@github-actions github-actions bot temporarily deployed to staging/pull/1962/bundle-report January 24, 2025 13:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/typedoc January 24, 2025 13:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/features January 24, 2025 13:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/features January 28, 2025 12:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/typedoc January 28, 2025 12:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/bundle-report January 28, 2025 12:40 Inactive
@VeskeR
Copy link
Contributor

VeskeR commented Jan 28, 2025

Evgeny is on holiday and a couple more PRs got merged into the main while this relase PR was opened. I updated the changelog to include the fix for #1955

@github-actions github-actions bot temporarily deployed to staging/pull/1962/bundle-report January 28, 2025 12:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/features January 28, 2025 12:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1962/typedoc January 28, 2025 12:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

useChannel hook can throw exception in the effect if connection is closed
2 participants