-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to add in 'publish message to channel including metadata' #545
Conversation
Add in 'publish message to channel including metadata', i.e. in the extras headers json, which I believe has to be done through calling the Message constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding this! a couple of minor suggestions though:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add integration test for this?
You can add it below
async def test_subscribe(self): |
@sacOO7 we already have tests for publishing with extras ably-python/test/ably/rest/restchannelpublish_test.py Lines 354 to 371 in b92c770
|
Thanks for pointing out @owenpearson ! |
Added changed suggested to align with PEP8 and make it a bit clearer
Thanks very much guys, appreciate this. I have committed those changes Owen, and hope I've done it correctly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add in 'publish message to channel including metadata', i.e. in the extras headers json, which I believe has to be done through calling the Message constructor.