[WEB-3649] Port JSX to TSX #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiehenson
changed the title
aleksandar-r
approved these changes
Mar 21, 2024
src/core/CustomerLogos/component.tsx
Outdated
| import React from "react"; | ||
|
|
||
| type CustomerLogosProps = { | ||
| companies: { |
There was a problem hiding this comment.
Should we create a some kind of company entity type here ?
public/mockServiceWorker.js
Outdated
| @@ -95,7 +95,7 @@ self.addEventListener("fetch", function (event) { | |||
|
|
|||
| // Bypass navigation requests. | |||
| if (request.mode === "navigate") { | |||
| return; | |||
| return; | |||
There was a problem hiding this comment.
This seems unnecessary change.
There was a problem hiding this comment.
The linter strikes again. I added to the .prettierignore to exclude this file, but something slipped through. I shall update to remove this from the diff
| <p className="ui-meganav-media-heading"> | ||
| Status | ||
| <iframe | ||
| title="Ably status" | ||
| src="https://status.ably.com/embed/icon" | ||
| allowtransparency="true" |
There was a problem hiding this comment.
Finally, this thing is being taken care of, it really annoyed me 🥇
There was a problem hiding this comment.
It's weird how React and the DOM have no real way to agree on this. React hates this form, the DOM hates allowTransparency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket Link / Motivation
https://ably.atlassian.net/browse/WEB-3649
Summary of changes
Takes every JSX file in this repo and converts it to TSX, introducing additional supporting types that are present across the assets.
I only performed the minimum changes, that is, rename the file extension and do what is needed to appease TSC - no other logical changes have been made (where possible).
There's a host of JS assets as well, but this repo is big enough.
How do you manually test this?
Pull down, pull packages,
yarn storybook, it works.Reviewer Tasks (optional)
Merge/Deploy Checklist
Frontend Checklist