Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy--update-minibuffer): allow to resumed using stale data f… #2762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kiennq
Copy link
Contributor

@kiennq kiennq commented Dec 16, 2020

…rom dynamic collection.

This change is allow to resume to staled data from dynamic collection.
Of course we can always use ivy-occur but ivy-occur is taking a whole window + not an obvious choice to go to it after resuming from a dynamic collection (like counsel-rg).
Also, ivy-occur for counsel-rg doesn't work on Windows due to different path separator.

This change add new customize value of ivy-resume-with-staled-data and allow user to resume with stale data instead.
That would save (in most time) one more search and position in search list when resuming.
Solution for #1095 (comment)

Copy link
Collaborator

@basil-conto basil-conto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this code, but apart from a couple of nits it looks fine to me, thanks.

ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
@kiennq kiennq changed the title ivy.el (ivy--update-minibuffer): allow to resumed using staled data f… ivy.el (ivy--update-minibuffer): allow to resumed using stale data f… Dec 16, 2020
@kiennq
Copy link
Contributor Author

kiennq commented Dec 19, 2020

@abo-abo Can you help take a look to see if this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants