Fix for issue #2805 by using company-finish on counsel-company. #2835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change that makes
counsel-company
work more seamlessly withcompany-complete
. By usingcompany-finish
instead ofivy-completion-in-region-action
many behaviors expected from company, like'keep-prefix'
option and post-complete hooks now work.This change needs that
company-abort
be called only ifivy-exit
is nil when unwinding, otherwisecompany-finish
does not work.