Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helper to generate entity ids #11

Merged
merged 3 commits into from
Jan 22, 2025
Merged

add helper to generate entity ids #11

merged 3 commits into from
Jan 22, 2025

Conversation

SirCotare
Copy link
Contributor

No description provided.

@SirCotare SirCotare self-assigned this Jan 22, 2025
@SirCotare SirCotare requested a review from ThoSap January 22, 2025 09:20
Copy link
Contributor

@ThoSap ThoSap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but keep in mind that we also have some EntityId<String> as for example for the Role.ID, Authority.ID and User.ID in the Finstral Composer Project.

@SirCotare
Copy link
Contributor Author

Nice, but keep in mind that we also have some EntityId<String> as for example for the Role.ID, Authority.ID and User.ID in the Finstral Composer Project.

I added some generic string version of the method. I know it will not be usable in some cases where the ID has to follow some special rules but in general that should do.
Also, string ids are probably very rare anyway in our systems.

@SirCotare SirCotare merged commit 9a37b74 into main Jan 22, 2025
1 check passed
@SirCotare SirCotare deleted the add_faker_id_generator branch January 22, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants