Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get or none on Package manager #127

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Add get or none on Package manager #127

merged 2 commits into from
Jun 23, 2023

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jun 23, 2023

No description provided.

@TG1999
Add get or none on Package manager
fd269e9 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@JonoYang JonoYang force-pushed the package_manager_get_or_none branch from 39effb4 to 84dbc54 Compare June 23, 2023 22:24
@JonoYang
Update logic in create_source_repo_packages
2771cf9 
    * Reduce the number of times .save() is called
    * Skip row if we do not find the package a row is for in the database
    * Ensure that the source_package's package_set value is the same as the package_set value of the binary package.

Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang force-pushed the package_manager_get_or_none branch from 84dbc54 to 2771cf9 Compare June 23, 2023 22:47
@JonoYang
Copy link
Member

@TG1999 Thanks for adding get_or_none, this is really helpful! I've updated the logic in create_source_repo_packages.py and I think it's good to be merged. I am still working on figuring out the best way to handle the issue where many packages have the same source repo.

@JonoYang JonoYang merged commit 888fcda into create-source-archives-command Jun 23, 2023
@JonoYang JonoYang deleted the package_manager_get_or_none branch June 23, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TG1999 @JonoYang